Skip to content

Ignore private changes and comments #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

karlatec
Copy link
Contributor

@karlatec karlatec commented May 6, 2025

Do not process events from changes which are either private or belong to branches where anonymous user doesn't have access (e.g. refs/meta/config branches).

If it's not readable by anonymous user - don't run it.

@karlatec karlatec marked this pull request as draft May 6, 2025 14:54
@karlatec karlatec marked this pull request as ready for review May 6, 2025 15:02
@karlatec karlatec requested a review from tomzawadzki May 7, 2025 13:03
@karlatec karlatec force-pushed the karlatec/skip-more-builds branch from cf83183 to e6813a5 Compare May 13, 2025 09:51
@karlatec karlatec requested a review from mikeBashStuff May 13, 2025 09:59
@karlatec karlatec force-pushed the karlatec/skip-more-builds branch from e6813a5 to 81b80c0 Compare May 27, 2025 09:35
Do not process events from changes which are either
private or belong to branches where anonymous user
doesn't have access (e.g. refs/meta/config branches).

If it's not readable by anonymous user - don't run it.

Signed-off-by: Karol Latecki <[email protected]>
@karlatec karlatec force-pushed the karlatec/skip-more-builds branch from 81b80c0 to 69a8052 Compare May 27, 2025 14:08
Copy link
Contributor

@mikeBashStuff mikeBashStuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomzawadzki tomzawadzki merged commit 64c6f37 into spdk:main Jun 2, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants